search

mmorise / World

A high-quality speech analysis, manipulation and synthesis system
http://www.kisc.meiji.ac.jp/~mmorise/world/english
Other
1.17k stars 251 forks source link

CheapTrick does not reproduce the exact same numerical value for each run #63

Closed gillesdegottex closed 6 years ago

gillesdegottex commented 6 years ago

This commit reseed the pseudo-random number generator each time CheapTrick is called so that the numerical results are always exactly the same. This repeatability property is necessary for unit testing, e.g.

mmorise commented 6 years ago

Thank you for your proposal. I agree to your plan and would like to merge it. I hesitate to use global variable, but I have no idea that can fulfill your request without using it.

Once I am going to merge your request, but please give me a chance to modify the code. I will modify it so that the same result is obtained.

If you agree to this plan, I am going to merge your request.

gillesdegottex commented 6 years ago

Of course, modify it as you please. I just provide the idea and a draft of it. Thanks for the merge!