Closed mmornati closed 6 years ago
What is the gain of putting init
and migrate
externally?
For me I feel it's more pain so I'm not hip-hop-hooray about this :-p
Startup performace: the docker is starting quickly as it is not always running the migrate. The init can maybe remain as before 'cause it is checking the db size. Do you prefer anything automatic?
Oh yes, automatic!
please use node:8.9.1-alpine
I was about to do a PR but you beat me!
Startup performance: the docker is starting quickly as it is not always running the migrate.
I don't know how you will tackle this challenge. Can we do quick query on the DB to know which ghost version was running the last time the db was access ?
Restored automatic DB init and migration.
I'll test on my side :)
I let you to accept the pull request if all is ok on your side
I prefer to squash and merge. Do you?
With the new ENTRYPOINT operator into the Dockerfile we are now able to have ghost execute on the PID 1
MIGRATE PROCEDURE To slim the docker start process (and allow it to start quickly) the migrate command is now executed only on demand.
INIT PROCEDURE In the same way, during the first execution of the docker, we can initialize de database.