Upgrade Ghost to 1.21.1

mmornati / docker-ghostblog

Ghost Blog Docker Container

MIT License

10 stars 6 forks source link

Closed sr229 closed 6 years ago

sr229 commented 6 years ago

I also fixed the CI since it fails because it's not exiting to code 0

sr229 commented 6 years ago

@mmornati I think I triaged it on the root cause of failed builds:

It seems that the reason it fails is because ghost does not permit usage of CLI via root, I had to install su-exec on the builder to force it to install using node user
Permission errors are evident on the build, I think I need to do chowning to be able to get the result intended

sr229 commented 6 years ago

I also downgraded to 6-alpine since this is also the image used by official and it seems to work

pascalandy commented 6 years ago

LGTM.

I would curious to know why node 8 I crashing.

mmornati commented 6 years ago

No idea.... We migrated to node 8 long time ago and we never had problem. I will take a look this evening to the pull requests.

mmornati commented 6 years ago

I'm approving your changes but I will try to switch back to the latest node version. Good Job and thanks :)

pascalandy commented 6 years ago

Will work on it as well