mmornati / docker-ghostblog

Ghost Blog Docker Container
MIT License
10 stars 6 forks source link

Version 1.21.1 works, but there is an error during the build #29

Closed pascalandy closed 6 years ago

pascalandy commented 6 years ago

Something is not clean here. https://github.com/mmornati/docker-ghostblog/pull/28

under step 4

https://travis-ci.org/mmornati/docker-ghostblog/builds/340304432#L616

screen shot 2018-02-11 at 8 14 25 pm

QA

The image works normally

screen shot 2018-02-11 at 8 11 57 pm

Next step

Testing with node 6

pascalandy commented 6 years ago

UPDATE

I got the same error using node6-alpine

https://travis-ci.org/mmornati/docker-ghostblog/jobs/340307121#L600

I propose to continue to use node:8 and keep an eye on this bug.

mmornati commented 6 years ago

The issue is related to python during the npm package install. I think it is not included into the alpine image we are using. We can maybe change the image for the standard node 1 for the build stage and use the alpine only into the final one

pascalandy commented 6 years ago

Not following when you say

standard node 1

sr229 commented 6 years ago

@pascalandy the error happens because the dependency requires Python, which in relevant terms, you need a custom builder image that has Python and Node.js both installed. This can be hotpatched by apk add python python3 afaik.

pascalandy commented 6 years ago

Cool, make sense from the PR you submitted. Will test on my side.