mmottl / gsl-ocaml

OCaml bindings to the GSL (GNU Scientific Library).
Other
36 stars 10 forks source link

Fix dune rules #31

Closed rgrinberg closed 3 years ago

rgrinberg commented 3 years ago
mmottl commented 3 years ago

Thanks, I'll make a new release!

mmottl commented 3 years ago

@rgrinberg Btw., would there be any significant difference between these two lines:

(action (run ./foo.exe)) (action (run foo.exe))

If not, I'll use the shorter version in my packages.

rgrinberg commented 3 years ago

Yes, there’s a difference.

The first runs the binary foo.exe located relative to the dune file where the rule is.

The second runs foo.exe that is either in PATH or has public_name foo.

Rudi. On Mar 30, 2021, 3:40 PM -0700, Markus Mottl @.***>, wrote:

@rgrinberg Btw., would there be any significant difference between these two lines: (action (run ./foo.exe)) (action (run foo.exe)) If not, I'll use the shorter version in my packages. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

rgrinberg commented 3 years ago

Actually, I'm wrong about that. (run foo.exe) will look it up in PATH or relative to the dune file.

mmottl commented 3 years ago

Ok, so I assume that the explicit path is preferred? If it's safer, I'd rather use this form.

rgrinberg commented 3 years ago

I prefer the explicit form whenever possible for that reason