search

mmozeiko / pkgi

pkg download & installation directly on Vita
The Unlicense
248 stars 162 forks source link

Is it possible to merge pkgj? #62

Closed lunalik2 closed 6 years ago

lunalik2 commented 6 years ago

A lot of progress has been made with pkgj in the past year, and it might be unnecessary to re create all these features. I am not saying replace pkgi or anything, I am just suggesting making pkgj's features part of pkgi, so you can build further rather than starting from scratch. There hasn't been a commit here in a while, and this might be a good place to start. It would be great to see pkgi back in the game! I hope you consider this.

mmozeiko commented 6 years ago

Sorry, but this is not how pull requests work.

You don't create fork, do a hundreds of commits which changes everything and then submit one pull request with all the changes.

What you do, is you create pull request for specific features/bugs/issues that code changes. So pull request should be for specific feature A, different one for specific improvement B, another for specific bug C, etc..

I would gladly accept pull requests, but they need to be logically simple, not these massive changes. As a minimum they also would need to be in same style as rest of the code. Not suddenly changing code from C to C++.

As for why there haven't been commits here, that's because my enthusiasm working on pkgi is pretty much zero. If you where not on Vita discord last year, then short background - people in Vita scene are super uncooperative, very non-collaborative and selfish. Instead of working on same goals, collaborating and contributing, many just wanted to take something that is made by others, slap their name on top of it, and be done (this is not only about pkgj). That's why my interest in continuing on pkgi went to the bottom of list of things that I want to do.

That said, there were a few helpful people that helped to improve pkgi. Unfortunately they where the minority.

lunalik2 commented 6 years ago

@mmozeiko Sorry probably should have tooken into account how big of a change that would be. And I am sorry to hear the community is that way. In these current circumstances, I can understand that this may be a bad place to start. So maybe it is time to make a new vita app? Since the vita scene is mostly dead, I’m not sure what would be best, but maybe that could be a sign to move on to the switch? As I don’t write in C, and never really wrote anything for a video game console, I don’t have a good idea of how difficult it is to switch from one to the other. But if it isn’t too difficult, the switch might be worth looking into. I hope you consider.