search

mmozuras / git-playback

Create visual playback of your commits
MIT License
169 stars 16 forks source link

Blank dark gray screen #2

Closed christiangenco closed 12 years ago

christiangenco commented 12 years ago

On Mac OS X 10.7.3 on both Google Chrome 18.0.1025.168 and Safari 5.1.3, the result of running git-playback[master*]% ./git-playback README.md generates playback.html as a blank dark gray screen.

From the Chrome developer Resources tab, the page appears to have successfully loaded highlight.min.js, jquery.min.js, and monokai.min.css. There are no errors in the javascript console.

This error occurs with every file I have tried to generate a playback.html for.

snaewe commented 12 years ago

"me too" on Windows XP, Google Chrome 18.0.1025.168.

mmozuras commented 12 years ago

Even if files didn't exist or were empty, empty divs were still created. In this case, README was not written until 10th commit. Thanks for pointing this out!

christiangenco commented 12 years ago

Issue still exists. Here's README.md's playback.html (looks like no lis were generated).

mmozuras commented 12 years ago

Heh, I managed to break it again. Fixed it (again). Time to think about a better way to test bash scripts than just "I'll just run it for this one case".

christiangenco commented 12 years ago

TDD ftw. Trying again...

mmozuras commented 12 years ago

Yeah, I guess I should use the same good engineering practices for bash scripts that I use for everything else ;) It's just doesn't come as natural to me yet.

christiangenco commented 12 years ago

I still need to get into the habit.

Now I see a static screen with README's first commit (sauce). All resources loaded correctly and there are no errors in the js console.

mmozuras commented 12 years ago

Yup, that is correct. At the moment, there is no autoplay or visual buttons. Use left and right arrows to navigate.

christiangenco commented 12 years ago

...OH! Wow, this makes a lot more sense. Can I update your README with an example and a sentence that says "visually navigate through your commits with the arrow keys" or something?

mmozuras commented 12 years ago

Thanks, will do! :-)