search

mmozuras / poper

Make sure git commit messages are well-formed
MIT License
77 stars 11 forks source link

Fix mmozuras/poper#15 (Pin rugged version to 0.23.X) #16

Closed ulyssesrex closed 3 years ago

ulyssesrex commented 4 years ago

The problem:

https://github.com/mmozuras/poper/issues/15

The test suite currently fails because of incompatibilities in version 0.99.0 of the rugged dependency. The dependency should be pinned to an older version to ensure compatibility.

The approach:

Currently, the gemspec uses ~> to set the version of the rugged dependency above 0.23.

This operator actually allows the final sequence of digits in the version string to increment to whatever is the most recent minor version release. In this case, 0.99.0 is the most recent version of rugged, so the 23 gets incremented to 99 during bundle install.

Adding an additional sub-version to the version string allows only the final 0 to be incremented. In this case, the most recent rugged 0.23.X sub-version is 0.23.3, which is compatible with poper and will allow the test suite to pass.

ulyssesrex commented 4 years ago

@mmozuras I'd be interested in your thoughts when you get a chance. Thanks!

jbielick commented 4 years ago

@mmozuras would you consider giving a member of our Org (Adwerx) contributor and publishing privileges?

ulyssesrex commented 3 years ago

I'm going to close this PR for now. Let me know if there's any interest in re-opening it.