search

mmp / pbr-book-website

Other
456 stars 62 forks source link

Maybe there are some typos #1

Open kanition opened 3 years ago

kanition commented 3 years ago

https://github.com/mmp/pbr-book-website/blob/02b496ae12670f8ffec2a6fe67cc30b07e57cba6/3ed-2018/Shapes/Other_Quadrics.html#L1355

I really like this amazing work and thank you for your sharing this book!

I have a problem with the implicit form of the hyperboloid: It is x^2+y^2-z^2=-1, which means that it is a two-sheet hyperboloid. But the parametric form shows that it is generated by a rotating line passing through points (x1,y1,z1) and (x2,y2,z2), which should be a one-sheet hyperboloid. Maybe the implicit form of the hyperboloid should be changed to x^2+y^2-z^2=1 for consistency.

Reference:https://en.wikipedia.org/wiki/Hyperboloid

kanition commented 3 years ago

https://github.com/mmp/pbr-book-website/blob/02b496ae12670f8ffec2a6fe67cc30b07e57cba6/3ed-2018/Shapes/Triangle_Meshes.html#L213-L215 Maybe there is another typo: I guess you meant "the number of edges and faces ... "

kanition commented 3 years ago

https://github.com/mmp/pbr-book-website/blob/02b496ae12670f8ffec2a6fe67cc30b07e57cba6/3ed-2018/Shapes/Triangle_Meshes.html#L2496-L2497

https://github.com/mmp/pbr-book-website/blob/02b496ae12670f8ffec2a6fe67cc30b07e57cba6/3ed-2018/Shapes/Triangle_Meshes.html#L2508-L2509

Maybe Figure 3.14 and its caption are inconsistent with the text. It should be: Left to the line: e(p)>0 Right to the line: e(p)<0 On the line: e(p)=0

kanition commented 3 years ago

https://github.com/mmp/pbr-book-website/blob/4c5c6f8f53434262a07a7c7a9bcde35e2dcd9bb6/3ed-2018/Shapes/Subdivision_Surfaces.html#L2687

Maybe you mean that "......the kth and PREV(k)th edges of the kth child need to be set"—— "ith child" should be changed to "kth child".

kanition commented 3 years ago

https://github.com/mmp/pbr-book-website/blob/02b496ae12670f8ffec2a6fe67cc30b07e57cba6/3ed-2018/Shapes/Managing_Rounding_Error.html#L1757

With e_b=255, non-zero significand bits correspond to special NaN values...

It should be "e=255" rather than "e_b=255".

kanition commented 3 years ago

https://github.com/mmp/pbr-book-website/blob/02b496ae12670f8ffec2a6fe67cc30b07e57cba6/3ed-2018/Shapes/Managing_Rounding_Error.html#L8932 Maybe the x∈... below "Using the bounds on d" should be x'∈....

Connor24601 commented 3 years ago

Hi @kanition, Fellow reader here. In the preface, the book states

As with earlier versions of the book, please send an email to authors@pbrt.org if you see any errors in the text or in the online conversion of it.

I recommend shooting them an email with this issue linked, if you haven't already.

kanition commented 3 years ago

Thank you for your advice. I'll try it.