mmp / pbr-book-website

Other
472 stars 64 forks source link

3.3.3 Coordinate System From a Vector - Equation wrong #18

Closed steimich96 closed 9 months ago

steimich96 commented 10 months ago

The equation in this section is wrong and does not fit the given implementation Link.

The "1-" should be moved in front of the fraction (out of the numerator). See also this post on math stackexchange: https://math.stackexchange.com/questions/4838905/coordinate-system-from-a-3d-unit-vector/4839260#4839260

mmp commented 9 months ago

Thanks for reporting this! It was actually in the errata since last May but the text wasn't fixed in the online book. The next push (in a few hours) will have it fixed.