possible (minor) bug in interaction.h

mmp / pbrt-v3

Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.

http://pbrt.org

BSD 2-Clause "Simplified" License

4.88k stars 1.19k forks source link

possible (minor) bug in interaction.h #137

Open grzegorz-k-karch opened 7 years ago

grzegorz-k-karch commented 7 years ago

Hello,

In https://github.com/mmp/pbrt-v3/blob/master/src/core/interaction.h#L70 shouldn't it be Vector3f d = p2 - origin; ?

Kind regards, Grzegorz Karch

mmp commented 6 years ago

Nice find--thank you! Now fixed.

mmp commented 6 years ago

This breaks the Triangle.Reintersect test for reasons that are no immediately obvious. Pushed a95b0bc97f79785dbbf2576019d730084677b492. Reopening for now.