Build fails with VC++ 2017

mmp / pbrt-v3

Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.

http://pbrt.org

BSD 2-Clause "Simplified" License

4.88k stars 1.19k forks source link

Build fails with VC++ 2017 #150

Closed Th30n closed 7 years ago

Th30n commented 7 years ago

The build fails here: https://github.com/mmp/pbrt-v3/blob/df8c1089524ebe1a4772b13b7e87d54e0aa58400/src/core/imageio.cpp#L306

It seems that some of the expected defines aren't set by the VC++ 2017 that ships with Visual Studio 2017 Community edition. Either that, or that line has an error and it should look for _WIN32 instead of WIN32 (no underscore)

Th30n commented 7 years ago

Argh, ignore this error. I've set the CMake to generate Win32 build instead of Win64 for VS. Perhaps this should be mentioned in the README.md.