search

mmp / pbrt-v3

Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.
http://pbrt.org
BSD 2-Clause "Simplified" License
4.88k stars 1.19k forks source link

Is TransformCache actually used? #153

Closed Narann closed 7 years ago

Narann commented 7 years ago

Hello!

First: Thanks for this wonderful book!

I'm reading the 3rd edition. The Transform chapter talk about TransformCache. But a tiny search indicate the class is not use at all.

Maybe a leftover?

Keep the good work! :)

mmp commented 7 years ago

(Glad you've enjoyed the book!)

You search seems to be incomplete (not sure why):

https://github.com/mmp/pbrt-v3/blob/b57b56cadd2e11ab3ad5d79b404234ca8b3871d9/src/core/api.cpp#L243

https://github.com/mmp/pbrt-v3/blob/b57b56cadd2e11ab3ad5d79b404234ca8b3871d9/src/core/api.cpp#L663

Narann commented 7 years ago

Thanks! I shouldn't have relied on Github search. I will search more carefully next time.

Keep the good work! :)