Closed ksmolenskiy closed 6 years ago
Hello! Shouldn't disk dp/dv (disk.cpp line 79) be Vector3f dpdv = Vector3f(pHit.x, pHit.y, 0.) * (radius - innerRadius) / rHit; instead of Vector3f dpdv = Vector3f(pHit.x, pHit.y, 0.) * (innerRadius - radius) / rHit; ??
Vector3f dpdv = Vector3f(pHit.x, pHit.y, 0.) * (radius - innerRadius) / rHit;
Vector3f dpdv = Vector3f(pHit.x, pHit.y, 0.) * (innerRadius - radius) / rHit;
https://www.wolframalpha.com/input/?i=d%2Fdv+((1+-+v)+*+r0+%2B+v+*+r1)+*+cos(phi)
You are correct. Thanks for reporting this!
Hello! Shouldn't disk dp/dv (disk.cpp line 79) be
Vector3f dpdv = Vector3f(pHit.x, pHit.y, 0.) * (radius - innerRadius) / rHit;
instead ofVector3f dpdv = Vector3f(pHit.x, pHit.y, 0.) * (innerRadius - radius) / rHit;
??https://www.wolframalpha.com/input/?i=d%2Fdv+((1+-+v)+*+r0+%2B+v+*+r1)+*+cos(phi)