search

mmp / pbrt-v3

Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.
http://pbrt.org
BSD 2-Clause "Simplified" License
4.88k stars 1.19k forks source link

Cygwin build fixes. #158

Closed tsulej closed 6 years ago

tsulej commented 6 years ago

Fixes all issues reported here: https://github.com/mmp/pbrt-v3/issues/155

What is done here:

  1. Minimum CMake bumped to 2.8.4 to remove long warning text under Cygwin
  2. noinline parentheses escaped
  3. Changed order of local thread keyword to select __thread first. __declspec(thread) is ignored under Cygwin.
tsulej commented 6 years ago

It seems that escaping parentheses breaks build under Visual Studio.

mmp commented 6 years ago

Thanks!