search

mmp / pbrt-v3

Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.
http://pbrt.org
BSD 2-Clause "Simplified" License
4.88k stars 1.19k forks source link

splitdepth integer in CreateCurveShape(...) #171

Closed wahn closed 6 years ago

wahn commented 6 years ago

Shouldn't the line 475 in src/shapes/curve.cpp be changed from:

int sd = params.FindOneFloat("splitdepth", 3);

to:

int sd = params.FindOneInt("splitdepth", 3);

In the documentation it says splitdepth has integer type, so it should be read by the matching function FindOneInt(...) in my opinion ...

mmp commented 6 years ago

Nice find--thanks! Fixed now.