mmp / pbrt-v3

Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.
http://pbrt.org
BSD 2-Clause "Simplified" License
4.87k stars 1.18k forks source link

obj2pbrt missing WorldBegin / WorldEnd #211

Closed serhii-rieznik closed 4 years ago

serhii-rieznik commented 5 years ago

It looks like obj2pbrt produces .pbrt files that are not readable by pbrt, because they are missing WorldBegin and WorldEnd lines.

emimvi commented 5 years ago

This seems to be intentional. From the users guide:

"Note that OBJ files only describe scene geometry; they don’t include camera specifications or descriptions of light sources. (Thus, the generated pbrt input file only includes shape and material specifications that you’ll need to add inside the WorldBegin/WorldEnd block of a full pbrt input file.) Unless you have camera and light source information separately, you’ll need to specify both on your own (see “General Tips” below for some ideas about how to do this.)" https://www.pbrt.org/users-guide.html#Converting_Scenes_to_pbrts_Format_0

mmp commented 4 years ago

Yep, that's intentional, and for that reason.