Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.
It would appear the SpectrumType isn't used anywhere in the new hand-rolled parser. As a reader, I found it confusing that it is set to different values, but not used. Are they supposed to be used? If no, please consider this pull request to remove them.
Additionally I removed the isString member on ParamListItem. I think it is vestigial, as you end up checking if item.stringValues or item.doubleValues was set in AddParam as an alternative to determining if the parameter is a string.
It would appear the
SpectrumTypeisn't used anywhere in the new hand-rolled parser. As a reader, I found it confusing that it is set to different values, but not used. Are they supposed to be used? If no, please consider this pull request to remove them.Additionally I removed the
isStringmember onParamListItem. I think it is vestigial, as you end up checking ifitem.stringValuesoritem.doubleValueswas set inAddParamas an alternative to determining if the parameter is a string.