mmp / pbrt-v3

Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.
http://pbrt.org
BSD 2-Clause "Simplified" License
4.86k stars 1.18k forks source link

A bug in OrthographicCamera::GenerateRay of pbrt-v3 #315

Open stanleyljl opened 2 years ago

stanleyljl commented 2 years ago

At the line 61 of orthographic.cpp,It seems that ray->o should be pCamera + Point3f(pLens.x, pLens.y, 0). It is more reasonable that the ray starts from a region around with pCamera for an ortho camera.