search

mmp / pbrt-v3

Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.
http://pbrt.org
BSD 2-Clause "Simplified" License
4.85k stars 1.18k forks source link

compilation error #335

Open oferyaron opened 1 month ago

oferyaron commented 1 month ago

Hi,

I downloaded the project. While compiling using MSVC I receive the following error:

Error C2039 'binary_function': is not a member of 'std' IlmImf-obj D:\pbrt-v3\src\ext\openexr\OpenEXR\IlmImf\ImfAttribute.cpp 66

Any idea why ?

Dy111111 commented 2 weeks ago

you can replace the nameCompare struct code of ImfAttribute.cpp with below struct NameCompare { bool operator()(const char *x, const char *y) const { return std::strcmp(x, y) < 0; } };

qiyuewuyi2333 commented 1 week ago

you can replace the nameCompare struct code of ImfAttribute.cpp with below struct NameCompare { bool operator()(const char *x, const char *y) const { return std::strcmp(x, y) < 0; } };

thx bro, you are right. .👍

oferyaron commented 1 week ago

Thanks!

בתאריך יום א׳, 23 ביוני 2024, 10:11, מאת qiyuewuyi2333 ‏< @.***>:

you can replace the nameCompare struct code of ImfAttribute.cpp with below struct NameCompare { bool operator()(const char x, const char y) const { return std::strcmp(x, y) < 0; } };

thx bro, you are right. .👍

— Reply to this email directly, view it on GitHub https://github.com/mmp/pbrt-v3/issues/335#issuecomment-2184753970, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVPLLF24J2A4WNNXGT2ZUMDZIZYL3AVCNFSM6AAAAABIJRDUVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUG42TGOJXGA . You are receiving this because you authored the thread.Message ID: @.***>