search

mmp / pbrt-v3

Source code for pbrt, the renderer described in the third edition of "Physically Based Rendering: From Theory To Implementation", by Matt Pharr, Wenzel Jakob, and Greg Humphreys.
http://pbrt.org
BSD 2-Clause "Simplified" License
4.92k stars 1.2k forks source link

[WIP] Vs2013 port, constexpr issue #48

Closed mjhsnps closed 8 years ago

mjhsnps commented 9 years ago

VS2013 doesn't truly support constexpr, and This causes the following error in sppm.cpp when invoking the macro: ..\src\integrators\sppm.cpp(61): error C2482: 'gridCellsPerVisiblePointmin' : dynamic initialization of 'thread' data not allowed

This update works around the lack of support by defining the equivalent constants.

Please let me know if I'm not conforming to any coding styles you have in place (either implicit or explicit). Also I have not built this on a non-VS system so this needs to be validated.

See mmp/pbrt-v3#8

mmp commented 8 years ago

Looks great--thanks!

Sorry for the delay in merging!