search

mmp / pbrt-v4

Source code to pbrt, the ray tracer described in the forthcoming 4th edition of the "Physically Based Rendering: From Theory to Implementation" book.
https://pbrt.org
Apache License 2.0
2.8k stars 429 forks source link

Update --display-server for recent improvements to tev's display protocol #111

Open mmp opened 3 years ago

mmp commented 3 years ago

Specifically, https://github.com/Tom94/tev/pull/113...

pbrt4bounty commented 3 years ago

I don't have a very free time, but I'm interested in improving this and also adapting it to send the render data to the Blender viewport. I think a good starting point is to review the code that @JiayinCao is using in his project SORT. https://github.com/JiayinCao/SORT

mmmovania commented 2 years ago

I am unable to use latest tev for display of the output from the latest pbrtv4 code. Using the --display-server localhost:14158 commandline option does nothing at all. Also if i use tev to display the rendered exr file from pbrt, tev closes immediately. Is this some issue with the pbrt --display-server setting not working for the latest source? I am on Windows 8.1 using visual studio 2019 x64. OK an update. It works fine with tev 1.21 but not with latest ver 1.22. Also if you run and tev does not update ensure that there is no tev instance running in the bg. Kill that running instance first and then it works.

mmp commented 2 years ago

Hmm, tev 1.22 works fine for me (Windows 10, MSVC 2019), both building from source and with the tev.exe for the 1.21 release. If I launch multiple instances of tev, it seems that the image is displayed in the first one. I'm not sure there is any pbrt bug here, but if you believe there is please file a new issue.

mmmovania commented 2 years ago

Hi Matt. I found the issue and its a tev issue. Filed and solved in #172.