Double precision is not working... for normals?

mmp / pbrt-v4

Source code to pbrt, the ray tracer described in the forthcoming 4th edition of the "Physically Based Rendering: From Theory to Implementation" book.

https://pbrt.org

Apache License 2.0

2.8k stars 429 forks source link

Double precision is not working... for normals? #377

Open pbrt4bounty opened 1 year ago

pbrt4bounty commented 1 year ago

Hi... I tried the fix applied here: https://github.com/mmp/pbrt-v4/issues/359 and everything seems fine now for the vertices, but I suspect the 'normals' require some tweaking as well. Result on GPU with 'float as double' ON and with fix applied: imagen Result in CPU: imagen

Cheers..!

mmp commented 1 year ago

Very strange; it's not immediately obvious why normals would have a problem. (As far as I know, they don't go through any dodgy pointer casts like vertex positions used to...)