mmp / pbrt-v4

Source code to pbrt, the ray tracer described in the forthcoming 4th edition of the "Physically Based Rendering: From Theory to Implementation" book.
https://pbrt.org
Apache License 2.0
2.89k stars 457 forks source link

Missing absolute in MAE? #442

Closed Hearwindsaying closed 1 month ago

Hearwindsaying commented 2 months ago

It seems that the absolute is missing when computing the difference for the MAE metric. https://github.com/mmp/pbrt-v4/blob/39e01e61f8de07b99859df04b271a02a53d9aeb2/src/pbrt/util/image.cpp#L560

mmp commented 1 month ago

Thanks for reporting this!