search

mmp / vice

Virtual air traffic control simulator
https://pharr.org/vice
GNU General Public License v3.0
23 stars 33 forks source link

STARS: should issue an error if we attempt to hand off to ourself #150

Closed mmp closed 5 months ago

mmp commented 6 months ago

Currently the track starts flashing, etc., like a regular handoff. (TODO: double check what the STARS manual says about this.)

checkandmate1 commented 6 months ago

I did this for quicklooks in #30, but I suppose handoffs/ pointouts should have this as well. Do you think this logic should live in calculateController or the respective method?

mmp commented 6 months ago

Probably not calculateController since I could imagine cases where it would be legit to get our own TCP ID from a calculateController lookup. I think it probably should be a check in Sim. (In general, it's good to have those sorts of checks there since it has the true view of the World. On the client side, the World may be slightly out of date due to other controllers' actions changing the World before we get an update. That's likely not an issue in this case, but in general it's good to do validation sorts of checks like this there..)

checkandmate1 commented 6 months ago

Sounds great