Fixed long scratchpads & added error checking for too long scratchpads

mmp / vice

Virtual air traffic control simulator

https://pharr.org/vice

GNU General Public License v3.0

23 stars 33 forks source link

Fixed long scratchpads & added error checking for too long scratchpads #172

Closed checkandmate1 closed 5 months ago

checkandmate1 commented 6 months ago

Fixing #171

vice will now shoot an error for invalid departure scratchpads.
Fixed the departure scratchpads for some scenarios

checkandmate1 commented 5 months ago

@mmp Should this PR be closed? Or is anything stopping me from merging it in for the release? (Or did we add in these features already in other commits?)

mmp commented 5 months ago

I think this got merged (and then I added a few more rules that I noticed in the STARS manual): https://github.com/mmp/vice/blob/d3fdaa1c09cfb77dd5463252b8122456b283cd55/stars.go#L3115. Though please double-check that nothing was missed..

checkandmate1 commented 5 months ago

For the part checking implied commands and seeing if it matches a TCP, I think it should first check the facility.

if ctrl.FaciliyIdentifier == "" && ctrl.SectorId == contents {
// etc...
}

mmp commented 5 months ago

For the part checking implied commands and seeing if it matches a TCP, I think it should first check the facility.
if ctrl.FaciliyIdentifier == "" && ctrl.SectorId == contents {
// etc...
}

Yep, good catch. Done and pushed. I will go ahead and close this but reopen if I've missed something.