search

mmp / vice

Virtual air traffic control simulator
https://pharr.org/vice
GNU General Public License v3.0
18 stars 25 forks source link

Add p31 josh #264

Closed JoshAviation closed 5 days ago

mmp commented 1 week ago

Is this the latest version (and does the latest version work for you)? There are some errors in the JSON like:

           "departure_routes": {
                 "17" {

a colon is missing after the "17"

JoshAviation commented 1 week ago

Sorry, it is my first time working on a vice file and it has been a while since coding in JSON.

On Mon, Jun 24, 2024 at 8:37 PM Matt Pharr @.***> wrote:

Is this the latest version (and does the latest version work for you)? There are some errors in the JSON like:

       "departure_routes": {
             "17" {

a colon is missing after the "17"

— Reply to this email directly, view it on GitHub https://github.com/mmp/vice/pull/264#issuecomment-2187691405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWLWXZY7OFNQTAW5XK7PFCDZJC3URAVCNFSM6AAAAABJ2YGY5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGY4TCNBQGU . You are receiving this because you authored the thread.Message ID: @.***>

mmp commented 1 week ago

No worries at all! Welcome aboard and let me know when it's ready to be merged.

jessie846 commented 5 days ago

@mmp this is ready to be merged

mmp commented 5 days ago

Looks great, thanks!

mmp commented 5 days ago

@JoshAviation how do you want to be listed in the credits (and what's your discord id so I can give you the facility data developer rule on the vice discord)?

JoshAviation commented 4 days ago

My discord id is 699418447175483436, with the username of joshuaav. Thank you.

mmp commented 4 days ago

Thanks; role added on the discord! Also, when people click the "info" button on the right side of the menubar, a window comes up that lists all of the contributors by name. Let me know if you're like your full name there, a shortened version, or something else.

JoshAviation commented 4 days ago

I’ll just take Josh Lambert

On Sat, Jun 29, 2024 at 17:03 Matt Pharr @.***> wrote:

Thanks; role added on the discord! Also, when people click the "info" button on the right side of the menubar, a window comes up that lists all of the contributors by name. Let me know if you're like your full name there, a shortened version, or something else.

— Reply to this email directly, view it on GitHub https://github.com/mmp/vice/pull/264#issuecomment-2198334420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWLWXZ4S47JQWYOCPK76LQ3ZJ4OKHAVCNFSM6AAAAABJ2YGY5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGMZTINBSGA . You are receiving this because you were mentioned.Message ID: @.***>

JoshAviation commented 4 days ago

Thank you for your help through this process, working with vice has been so much easier than other projects before.

On Sat, Jun 29, 2024 at 17:04 Joshua Lambert @.***> wrote:

I’ll just take Josh Lambert

On Sat, Jun 29, 2024 at 17:03 Matt Pharr @.***> wrote:

Thanks; role added on the discord! Also, when people click the "info" button on the right side of the menubar, a window comes up that lists all of the contributors by name. Let me know if you're like your full name there, a shortened version, or something else.

— Reply to this email directly, view it on GitHub https://github.com/mmp/vice/pull/264#issuecomment-2198334420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWLWXZ4S47JQWYOCPK76LQ3ZJ4OKHAVCNFSM6AAAAABJ2YGY5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGMZTINBSGA . You are receiving this because you were mentioned.Message ID: @.***>

mmp commented 4 days ago

Great, thanks, I've added you to the credits there as well. And I'm glad it's been a good experience working with vice!