search

mmshivesh / Python-Nova.novaextension

Python Extension for Panic's Nova editor for macOS
https://extensions.panic.com/extensions/works.creativecode/works.creativecode.python-nova/
22 stars 6 forks source link

Remove preferences for unsupported plugins #20

Closed guillaumealgis closed 1 year ago

guillaumealgis commented 2 years ago

It is my understanding that currently Nova does not support the textDocument/formatting and textDocument/rangeFormatting LSP commands : https://docs.nova.app/api-reference/language-client/#supported-language-server-features

From what I could gather, both the pyls-black and pyls-isort LSP plugins rely on these commands to edit the file. So until Nova supports more of the LSP spec, we should not "advertise" support for these plugins.

Please double-check my assumptions. That's what I understood of the state of things after digging around trying to make these plugins work, but I could be wrong. If anyone had any success making these work, please don't hesitate to correct me! ☺️

mmshivesh commented 2 years ago

I just did a 1:1 implementation of the LSP spec that the original Python LS implements under the assumption that Nova would quickly add support for it. However, since they've not reached feature parity yet, it does look like disabling the unsupported extensions would be a better option.

guillaumealgis commented 2 years ago

Hi @mmshivesh ! A few of my PRs have been waiting for approval for a while. If you don't have enough availability to maintain this extension I'd be happy to help ! 😊

I personally need Nova to have top notch support for Python (and imo its not there yet), and I think this extension is still the best candidate to go there. Would you consider adding people as co-maintainers ?

Cheers !