search

mmstick / cargo-deb

A cargo subcommand that generates Debian packages from information in Cargo.toml
615 stars 50 forks source link

Do not require symlinks to resolve #192

Closed blyxxyz closed 3 years ago

blyxxyz commented 3 years ago

If preserve-symlinks is enabled then symlinks don't have to resolve to be added to the package. This is e.g. useful for aliases for executables, where the symlink is in a different directory before being copied.

kornelski commented 3 years ago

I would prefer to minimize amount of configuration options users need to know about. Would it be possible to have some smart defaults for this?

For example, if symlink resolves to a file, then copy the file. If the symlink is "broken", then copy the symlink itself (possibly with a warning that suggests setting the config flag to silence the warning).

blyxxyz commented 3 years ago

Hm. That's a bit tricky because it means the behavior changes if the symlink starts resolving.

Maybe it should still be an error, just a more informative one with that same suggestion?

kornelski commented 3 years ago

Yeah, but what are the chances that it will start resolving?

Error with help text is a good idea.