search

mmstick / cargo-deb

A cargo subcommand that generates Debian packages from information in Cargo.toml
615 stars 50 forks source link

cargo-deb fails trying to strip unknown file formats #67

Open Razican opened 6 years ago

Razican commented 6 years ago

Hello,

I'm running cargo-deb in the SUPERAndroidAnalyzer/super repository, and I get the following error with three files, all of them command line completions:

strip:/home/razican/workspace/super/super/target/release/super.bash: File format not recognized
cargo-deb: Command strip failed to launch
  because: exit code: 1

The affected files are the following:

kornelski commented 6 years ago

How did this file get there?

Razican commented 6 years ago

They get generated in the build.rs build script. I guess it's good practice to generate the completions in the target directory, right?

Ideally, they should go to OUT_DIR, but there is no easy way to package those files in the cargo deb command.

kornelski commented 6 years ago

Indeed. Hmm, so cargo-deb needs a good way to distinguish between executables and other executable assets put in the target directory.

I could limit stripping only to native rust targets. Then stripping of everything else specified in package.metadata.deb.assets would be left up to build scripts...

Razican commented 6 years ago

That would be great, yes.

Razican commented 5 years ago

Hi @kornelski! Is there any news on this front?

kornelski commented 5 years ago

I haven't got time to implement this. Could you have a look yourself?

There's alredy built_binaries() method that should be plugged in.

Razican commented 5 years ago

OK, I will try to give it a look when I get some free time.

Razican commented 5 years ago

Hi, I just tried this again and it seems fixed. Is this the case?

Razican commented 4 years ago

Ping @kornelski

kornelski commented 4 years ago

No change since https://github.com/mmstick/cargo-deb/issues/67#issuecomment-392337187