search

mmtk / mmtk-core

Memory Management ToolKit
https://www.mmtk.io
Other
375 stars 69 forks source link

No need to atomically set VO bit in post_alloc? #1156

Open qinsoon opened 4 months ago

qinsoon commented 4 months ago

For allocators that have its allocation buffer, it seems unnecesary to set VO bit atomically.

https://github.com/mmtk/mmtk-core/blob/3be73b8048df17f1f2bd019d0b109488a2c5e313/src/policy/immix/immixspace.rs#L139-L142

https://github.com/mmtk/mmtk-core/blob/3be73b8048df17f1f2bd019d0b109488a2c5e313/src/util/metadata/vo_bit/mod.rs#L64-L71

wks commented 4 months ago

That's right. It should include all bump-pointer allocators and the native MarkSweep, too (because each thread allocates in its own block).