search

mmtk / mmtk-core

Memory Management ToolKit
https://www.mmtk.io
Other
371 stars 67 forks source link

Add CI for tracing tools #903

Open caizixian opened 1 year ago

caizixian commented 1 year ago

At least some simple tests to make sure that the tracepoints are there, and are fired. We can check how bpftrace does their tests https://github.com/iovisor/bpftrace/blob/master/.github/workflows/ci.yml

qinsoon commented 1 year ago

I thought about this when I looked at the PR https://github.com/mmtk/mmtk-core/pull/898. My feeling is that the Rust code for the probe is the primary focus of the PR. The accompanying scripts (bpf scripts and Python scripts) are example uses of the tool, and are considered secondary in this context. The decision on whether to include tests for the scripts or not largely rests on the author's discretion. So I did not request tests to be included for the original PR.

If you feel the necessity to include tests, I would suggest adding tests as soon as you can.