search

mmtk / mmtk-julia

Julia binding for MMTk
13 stars 9 forks source link

Setting up a small set of tests to run from mmtk-core's CI #97

Closed udesou closed 1 year ago

udesou commented 1 year ago

LGTM. The test passed in mmtk/mmtk-core#941 in roughly 1 hour.

I've changed it a bit. I noticed that there's a rebuild after patching the tests. If we do the patching before the build, it should bring the time down further as we only build it once.

qinsoon commented 1 year ago

LGTM. The test passed in mmtk/mmtk-core#941 in roughly 1 hour.

I've changed it a bit. I noticed that there's a rebuild after patching the tests. If we do the patching before the build, it should bring the time down further as we only build it once.

Yeah. I noticed that as well. For CI in mmtk-julia, it seems we also do a rebuild.

udesou commented 1 year ago

I've created a subitem to apply the patches before the build for the CI in mmtk-julia as well.

qinsoon commented 1 year ago

With the new changes, the script failed here: https://github.com/mmtk/mmtk-core/actions/runs/6079604369/job/16492333680?pr=941