Closed eileencodes closed 6 months ago
Merging master fixes the remaining compilation errors I'm seeing locally. Happy to send a PR for that as I've already fixed the conflicts. I'm not sure how this repo prefers to sync with upstream.
Actually we need this change too, then it compiles https://github.com/mmtk/ruby/pull/64
That must be a typo. We used to use #ifdef USE_MMTK
, but switched to #if USE_MMTK
later.
I noticed that in CI and locally the
mmtk
branch wasn't compiling and failing on the following compilation errors:The
internal/mmtk_support.h
header is included fine, but these two lines were usingifdef USE_MMTK
rather thanif USE_MMTK
. Changing these allows CRuby mmtk branch to get past these compilation errors.See https://github.com/mmtk/ruby/actions/runs/8416953029/job/23044511739 for an example of these errors.