search

mmtk / ruby

Fork of The Ruby Programming Language [mirror], with added support for MMTk
https://www.ruby-lang.org/
Other
0 stars 1 forks source link

Fix missing type for `rb_debug_rstring_null_ptr` #64

Closed eileencodes closed 5 months ago

eileencodes commented 5 months ago

I don't really understand how this type went missing since it's on the upstream version. Maybe a bad rebase/merge? Either way this fixes the following compilation error.

string.c:437:1: warning: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
rb_debug_rstring_null_ptr(const char *func)
^
int
string.c:437:1: error: conflicting types for 'rb_debug_rstring_null_ptr'
./include/ruby/internal/core/rstring.h:364:6: note: previous declaration is here
void rb_debug_rstring_null_ptr(const char *func);
     ^

Combined with https://github.com/mmtk/ruby/pull/63, the mmtk branch successfully compiles on my machine.

wks commented 5 months ago

I think I made a mistake when merging the master branch. It happened in https://github.com/mmtk/ruby/commit/96df681952a8df2b28c63b33160548333ec13d15