search

mmtrt / Wine-AppImage_old

Issue tracker repo for ---> https://github.com/mmtrt/Wine_Appimage_old
0 stars 0 forks source link

Hard coded wineprefix #7

Closed smichel17 closed 4 months ago

smichel17 commented 5 years ago

Would it be possible to dynamically set the prefix based on the WINEPREFIX environment variable, rather than hard coding to ~/.wine-appimage-lol?

For context, see the context section of https://github.com/lutris/lutris/pull/2244

Right now I'm working around it with a bash wrapper to symlink the hard coded prefix to the actual install location, but this is really a hack and brings its own set of issues.

mmtrt commented 5 years ago

can you try build from continuous release.

smichel17 commented 5 years ago

Works! And defaults to ~/.wine if undefined. I think it'd be reasonable to

export WINEPREFIX=${WINEPREFIX:-$HOME/.wine-appimage-lol}

It'd also be nice to do the same thing for WINEDEBUG, to help with getting logs when people are having trouble getting it to run.

mmtrt commented 5 years ago

Pushed some changes now it should be good though I've not tested these changes except WINEPREFIX WINEDEBUG.

smichel17 commented 5 years ago

Seems to work for me! Let me know when you're ready for the next release so I can update the Lutris installers to use the new builds :)

mmtrt commented 5 years ago

builds from continuous should be usable.

smichel17 commented 5 years ago

Yeah, we decided to use it, but rehost it so we can link to a static file. Anyway, my issue is solved; you can close this issue or leave it open if you'd rather wait for a release. Thank you for the quick responses :)