Replace punycode and update dependancies

mmucklo / email-parse

Email\Parse is a multiple (and single) email address parser for php that is reasonably RFC822 / RFC2822 compliant.

MIT License

46 stars 15 forks source link

Closed olssonm closed 1 year ago

olssonm commented 2 years ago

This PR replaces the unmaintained true/punycode with symfony/polyfill-intl-idn to achieve the same results.

Also updates dependancies be able to use the package with modern frameworks where psr/log ~2.0 or ~3.0 is used.

Tested on PHP7.1 -> PHP8.1; tests clear and updates in this PR should be backwards compatible.

glensc commented 2 years ago

looks like this should be instead three merge requests

olssonm commented 2 years ago

@glensc Hmm, not quite sure I understand? "This should be"...?

glensc commented 2 years ago

I mean it's too many unrelated changes in a single pull request.

but I'm not a maintainer here, just sharing my opinion.

mmucklo commented 1 year ago

Sorry for the delay on this. Sounds like a good step forward, let me see why the tests have failed.

mmucklo commented 1 year ago

Okay, I picked out the relevant changes and merged them separately.

Thanks so much for this PR as it helped guide what needed to be done.