Some fixes I did while implementing this server.

[leamas]

Second attempt, found a bug.

As header says. Commenting in patches is hopefully sufficient(?). Some examples of the group header output in #10. The "Modify group header to reflect snarfing." patch tries to address #12 in it's own way.

Most of these should be simple to rebase to current master, the exception being the two group header patches.

[leamas]

Some screenshots for the group header:

[13:02:51] <@sochotni> leamas: but it's 3 commits on top of release
[13:03:12] <@sochotni> only 75dc8c10935315cf01dfd44e13c8f24e084368d3 is really needed for a fix I'd wager    
[13:03:13] <al-bot> Talking about 75dc8c1?
[13:03:14] <al-bot>     75dc8c1: Make sure Mock.init() is invoked before other usage (TBD)    
[13:03:14] <al-bot>     View: https://fedorahosted.org/FedoraReview/changeset/75dc8c1
[13:03:15] <@sochotni> yeah
[ 13:03:30] <@sochotni> al-bot: thank you oh might bot
[13:03:30] <al-bot> sochotni: Error: "thank" is not a valid command.
[13:03:50] <@sochotni>  too bad :-)

and

[13:47:11] <al-bot> Alec Leamas pushed 3 commit(s) to origin/devel at fedora-review
[13:47:12] <al-bot>     1216801: Make sure Mock.init() is invoked before other usage (#912182)
[13:47:13] <al-bot>     View: https://fedorahosted.org/FedoraReview/changeset/1216801     
[13:47:14] <al-bot>     6526c26: Ensure we run correct mock binary
[13:47:15] <al-bot>     View: https://fedorahosted.org/FedoraReview/changeset/6526c26
[13:47:16] <al-bot>     b493e1c: Ensure we run correct mock binary
[13:47:17] <al-bot>     View: https://fedorahosted.org/FedoraReview/changeset/b493e1c03:35] <@sochotni>     too bad :-)

[mmueller]

I implemented the shaSnarfing option in master. Can you split out your pull requests into logically separate features? For example, open a pull request with only the "group commits header" feature? There are some unrelated changes in this pull request that I don't want to merge.

[leamas]

Well, sure I could. But can't you just pick the commits you are interested in? You don't have to merge the complete request, you have the opportunity to pick the individual commits IIRC