search

mmueller / supybot-git

A Git plugin for Supybot (a Python IRC bot)
45 stars 24 forks source link

Unsupported GitPython #22

Open kapitanluffy opened 11 years ago

kapitanluffy commented 11 years ago

I was trying to install this but everytime i load it it raises an exception telling me I have an unsupported version of GitPython.

But when I try to check the gitpython's version in the terminal. It shows 0.3.2 I also triied looking for the package info in yum and it showed 0.3.2

I tried printing the git.version and it showed just a blank line. The directory for the supybot-git is named 'Git' in the plugins directory.

mmueller commented 11 years ago

I'm confused. The latest released version of GitPython is 0.3.2 RC1, which behaves as follows for me:

>>> import git
>>> git.__version__
'0.3.2 RC1'

If you're running GitPython from their git source, the version string will be 'git', which would be a problem. If you want, you can replace the test with a hard-coded version and see if it works for you:

#if not git.__version__.startswith('0.'):
#    raise Exception("Unsupported GitPython version.")
#GIT_API_VERSION = int(git.__version__[2])
GIT_API_VERSION = 3

I'm thinking maybe I should remove the check and just always assume it's >= 0.3.x now. I doubt many people are running the previous version anymore.

trasher commented 8 years ago

I've got the same issue. Here is the output:

Python 2.7.10 (default, Sep 24 2015, 17:50:09) 
[GCC 5.1.1 20150618 (Red Hat 5.1.1-4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import git
>>> git.__version__
'1.0.1'

Hardcode changing GIT_API_VERSION seems to solve the issue; thank you.