search

mmueller / supybot-git

A Git plugin for Supybot (a Python IRC bot)
45 stars 24 forks source link

Github API has changed #23

Closed myoung34 closed 11 years ago

myoung34 commented 11 years ago

The github API has shutdown API V2: https://github.com/blog/1160-github-api-v2-end-of-life

The code still references this code:

File "/home/marcus.young/repos/Supybot-0.83.4.1/plugins/Git/plugin.py", line 79, in commits
data = self._fetch_json('http://github.com/api/v2/json/commits/list/%s/%s?author=%s' % (repo,branch_path,author))
mmueller commented 11 years ago

I don't understand -- there is no explicit Github support in supybot-git. Is this a patch you applied yourself?

myoung34 commented 11 years ago

Nope, it's a stacktrace from running @Git commits

myoung34 commented 11 years ago

I may have submitted too quickly from a tl;dr'ed stacktrace, this might be from gitpython

mmueller commented 11 years ago

I don't see any direct uses of a hard-coded github.com URL in GitPython's code either (outside of one test case).

The file you quoted in the first message of this issue is my Git plugin, for sure, but that's not my code. Maybe you're running a fork of it? This is a search for "github" in supybot-git's code: https://github.com/mmueller/supybot-git/search?q=github&ref=cmdform

Or is Python being clever in the stack trace and showing the value of the format string, even though it came from your git.ini file?