mmuench55 / quiche-recipe

Recipe for spinach quiche.
https://mmuench55.github.io/quiche-recipe/
0 stars 0 forks source link

Scoring Rubric #1

Open jgagne opened 7 years ago

jgagne commented 7 years ago

HTML & CSS Recipe To-Dos

20 to-dos, 5 points each; 5 extra credit to-dos

Essential

Code

35 points

Design

40 points

Test

15 points

Git

10 points

Extra Extra

25 points

jgagne commented 7 years ago

Stellar work! However, consider updating the markup to remove the horizontal scrollbar.

horizontal-scrollbar

For example

HTML

<header>
  <div class="max-width">
    <h1>…</h1>
  </div>
</header>

CSS

body {
  margin: 0;
}

.max-width {
  max-width: 60em:
  padding: 0 1em:
  margin: 0 auto:
}

header {
 background: #030;
}
jgagne commented 7 years ago

Also, while you're in there, make your title font-size smaller to fit small width screen, then use a media query to bring it back to the larger, original, size for wider width screens. I'll hush for now.

jgagne commented 7 years ago

#makeitstop

footer-link

Please, center align the text and style the color of that link. (Please…)