search

mmuman / gfalist

Reads tokenized GFA BASIC version 3.x source files (.GFA) and converts them to human readable ASCII listings (.LST).
GNU General Public License v2.0
13 stars 5 forks source link

Unable to process GFA BASIC version 3.x source files #4

Open adegani opened 5 years ago

adegani commented 5 years ago

Hi, I've tried to convert a GFA 3 tokenized source to a .LST file, but I've received the error:

Version 3 files not supported yet.

By looking at the source code, in fact, it seems that the source made with older than ver. 4 are not supported. Now, I'm little confused :) because the README of the repo says

Reads tokenized GFA BASIC version 3.x source files (.GFA) and converts them to human readable ASCII listings (.LST).

What I'm missing?

Thank you so much PS: If you need some hand in order to implement ver.3 support, probably I can do something. The problem is that I've not yet found a GFA tokenized format reference :)

adegani commented 5 years ago

UPDATE: I've disabled the .GFA file version check in gfalist.c and it seem that it works with GFA 3 files. I've tried 5 different .GFA and I don't see any issues. There are some reason to say that ver 3 file are not supported?

mmuman commented 5 years ago

Well I don't really know, I didn't write it, I just fixed it for 64bit because I needed it, and put it on github. I don't know much more about GFA either.

adegani commented 5 years ago

Ok, anyway, I've found a quick-n-dirty fix for my problem. Let me know if you want to integrate that in your code!

kollokollo commented 5 years ago

yes, I would be interested in that fix.

kollokollo commented 5 years ago

I crated a pull request with my solution to this issue. Like it?

adegani commented 5 years ago

Good! My fix was more or less the same!