search

mmurdoch / arduinounit

ArduinoUnit is a unit testing framework for Arduino libraries
MIT License
394 stars 51 forks source link

Change SerialReporter to report to any Print subclass #15

Closed mmurdoch closed 11 years ago

mmurdoch commented 11 years ago

Since SerialReporter only calls methods defined on Print (and no longer calls Serial.begin() or any other Serial-specific methods) it could easily be extended to work with any subclass of Print e.g. by passing one to a new SerialReporter constructor (perhaps using Serial as a default). This would likely warrant a name-change (PrintReporter?) but doing so could be construed as a breaking change.

wmacevoy commented 11 years ago

I'm for the change --- it's not a serial reporter any more. DefaultReporter might be a little more future-proof.

mmurdoch commented 11 years ago

SerialReporter doesn't exist in 2.x. Since this is a breaking change in the 1.x code line it won't be applied there either. Therefore I'm closing this issue.