search

mmurdoch / arduinounit

ArduinoUnit is a unit testing framework for Arduino libraries
MIT License
394 stars 51 forks source link

Improve confusing test summary output #18

Closed mmurdoch closed 11 years ago

mmurdoch commented 11 years ago

The standard summary output is confusing as it isn't clear at a glance which counts correspond to which result category (tests run, successful tests or failed tests). A successful test run produces output like this which at first seems to indicate 1 failed test...

Running test suite...
Tests run: 1 Successful: 1 Failed: 0

See also comment in this Firmata issue: https://github.com/firmata/arduino/pull/41

mmurdoch commented 11 years ago

Suggest that any change in this area is done in 2.0 as there are client libraries (e.g. Arduino-TestSuite: https://github.com/jeroendoggen/Arduino-TestSuite) which parse the current output format.

wmacevoy commented 11 years ago

2.0 currently does not have "Running test suite..." to start and ends with a summary of the form:

test summary: 1 passed, 1 failed, and 0 skipped, out of 2 test(s).

mmurdoch commented 11 years ago

This seems much better to me. The simple act of putting the number before the result category makes this much clearer. I think we should stick with this in 2.x, backporting it to 1.x if absolutely necessary.

mmurdoch commented 11 years ago

Test summary output is clearer in 2.x. Closing this issue. If we want to backport it to the 1.x line then we'll open another issue.