mn416 / QPULib

Language and compiler for the Raspberry Pi GPU
Other
429 stars 64 forks source link

Moved PR's to development branch. #17

Closed wimrijnders closed 6 years ago

wimrijnders commented 6 years ago

This moves the previous PR on master to the development branch.

First PR: Check for mode flags, set Emulation Mode as default if no flags supplied

At least one of the define's DEBUG_MODE and EMULATION_MODE must be set for the library compilation This is a safeguard for giving an understandable warning when neither are set, and for sets a default. Not doing this will otherwise result in strange compilation errors.

While the makefile adequately handles these define's, the code might change later on in which the given situation occurs.

As an extra, this commit adds a .gitignore to the project.


In addition, the makefile has been adjusted in the following way:

wimrijnders commented 6 years ago

Getting the hang of it again; while doing previous, I recalled that you're supposed to put changes on separate branches before creating PR's. I will better my ways, hope the above is in order.

mn416 commented 6 years ago

Thanks, merged. I would suggest updating the "getting started guide" as I think they are no longer correct after this PR.

wimrijnders commented 6 years ago

Yes, was on to that. In addition, I found that the first change needs fixing

Was hoping to add the fix to this PR but alas too late. Not a problem, will make a new PR tomorrow.

BTW, I would not have been offended if you blocked the PR just for the text change. You can be as anal as you want to be with me and then some. I value stern code reviews, makes for better quality.