mn416 / QPULib

Language and compiler for the Raspberry Pi GPU
Other
430 stars 63 forks source link

Makefile wrong -D flag #4

Closed Joonho365Han closed 7 years ago

Joonho365Han commented 7 years ago

The QPU_MODE should be enabled if QPU>1 for make argument. Current Makefile sets -DEMULATION_MODE if QPU>1.

mn416 commented 7 years ago

Hi @Joonho365Han ,

Thanks for the report.

If I build with make QPU=1 target then QPU_MODE is enabled and EMULATION_MODE is disabled. If I build with make target then EMULATION_MODE is enabled and QPU_MODE is disabled. Is this not sufficient?

This is the second report I've received about the QPU makefile option, so I'm starting to think I'm missing something!

Joonho365Han commented 7 years ago

Oh I See! So the value "1" refers to "true" for enabling QPU. I thought it meant "number of QPUs to be used." Sorry for the confusion.