mn6 / nook-desktop

Desktop version of Nook, since Chrome MV3 will render it unusable
227 stars 28 forks source link

Add option for local weather checks #4

Open niels-beier opened 1 year ago

niels-beier commented 1 year ago

I already suggested this at https://github.com/mn6/nook/issues/15. The local weather could influence which theme (standard, rainy or snowy) of the selected game should be played and whether rain sounds should be played or not.

mn6 commented 1 year ago

Need to flesh this idea out more in my head, not sure how the dropdown would look.

Would the user still be able to select "rainy" versions whenever they want, or would all of the different weather options be removed from the dropdown and only retain the base games, choosing the version based on the weather?

If so, what would happen when it's raining and the GC version is selected, since there's no rainy version of the themes?

robinfriedmr commented 1 year ago

I could see this being a toggle like the one for Grandfather Mode. Or a drop-down with user-populated locales? (If someone wanted to have more than one location included.)

There is a related question of whether someone enters the locale, or if they are allowed to add one based on their device's location. And then probably disabling local weather data during offline mode? (For storing weather data locally, maybe a 14-day forecast cache that only includes whatever the general idea is for weather instead of hourly or quarter-hourly checks.)

For games that lack weather changes or that have other themes (sakura?), that does raise different questions.

SplenectomY commented 8 months ago

Hello! I've got a working build of this idea going here: https://github.com/SplenectomY/nook-desktop/

A free API key from WeatherAPI.com is all that's needed. Just plug it in and hit the checkbox.

Rain sounds will automatically fade out when the weather isn't rainy, and it will fade back to the volume specified when it starts to rain.

"Sunny" or "Clear" weather currently includes everything that doesn't have the "rainy" or "snowy" suffix in the game songs list, to answer the question about how to handle sakura theme.

image

I'm going to be testing, bugfixing, adding a few UI elements and polishing over the next couple weeks.

Build it yourself, or I have a Windows build up for grabs here: https://github.com/SplenectomY/nook-desktop/releases/

Edit: A few more comments -