Update GitHub actions - Githubissues

mna / pigeon

Command pigeon generates parsers in Go from a PEG grammar.

BSD 3-Clause "New" or "Revised" License

845 stars 68 forks source link

Update GitHub actions #162

Closed meyermarcel closed 1 week ago

meyermarcel commented 1 week ago

actions/checkout v4 is available
actions/setup-go v5 is availabe, v4+ has an integrated cache
- Caching in ci.yml was removed
- Caching in go-cross.yml was not touched because more stuff is cached
actions/cache v4 is available
golangci/golangci-lint-action is available and has CI optimized caching integrated
Go 1.23 (current stable) can check clean dependencies with go mod tidy -diff
actions/go-dependency-submission v2 is available

meyermarcel commented 1 week ago

Hey @breml , I love this great library and I saw that some GitHub actions could be updated. Sorry for changing so much. If you want the PR to be a smaller scope I can shrink the scope of the PR, please let me know :)

Suggestions:

Instead of v1.62.0 v1.62 would use also fixes to golanci-lint.
Go version in ci.yml (stable -> 1.23) diverges from go.mod (1.22.0).
- Maybe using 1.22 instead of 1.22.0 would not pin to a specific patch version
- We could use go-version-file: "go.mod" (see actions/setup-go docs) to use the Go version defined in go.mod.

breml commented 1 week ago

Hey @breml , I love this great library and I saw that some GitHub actions could be updated. Sorry for changing so much. If you want the PR to be a smaller scope I can shrink the scope of the PR, please let me know :)

PR size is fine for me.

Suggestions:

Instead of v1.62.0 v1.62 would use also fixes to golanci-lint.

I am fine with v1.62 instead of v1.62.0.

Go version in ci.yml (stable -> 1.23) diverges from go.mod (1.22.0).

This is not a problem. This can stay as is.

Maybe using 1.22 instead of 1.22.0 would not pin to a specific patch version

Agree, you may change this to 1.22.

We could use go-version-file: "go.mod" (see actions/setup-go docs) to use the Go version defined in go.mod.

I prefer to keep it explicit to stable and oldstable.

meyermarcel commented 1 week ago

Maybe using 1.22 instead of 1.22.0 would not pin to a specific patch version

Agree, you may change this to 1.22.

Maybe I do not know how this works. If I change to 1.22 the toolchain definition becomes my local toolchain -> toolchain go1.23.3. So maybe it is better to leave it as it is. I changed only the golangci-lint version.