mnakada / atomcam_tools

Hack tool for atomcam and wyzecam.
Other
183 stars 22 forks source link

web server English version #42

Closed virmaior closed 2 years ago

virmaior commented 2 years ago

I went ahead and translated the titles in the vue page into English (https://github.com/virmaior/atomcam_tools/commit/7346b2e180408737395bffee876572c022be47ea) but I'm not sure how best to contribute this to atomcam_tools.

This should be useful for any developers outside of Japan who are working on bringing similar functionality to wyze .

HTMLとJSは知っているけど、VUEは全然知らない. And looking at VUE's il8n method, it looks it would be more annoying than helpful to use since it would make it so every title and tooltip needs to be a variable for substitution.

mnakada commented 2 years ago

I had not thought about i18n because atomcam was for Japan only. I will consider Vue-i18n.

mnakada commented 2 years ago

@virmaior , I have isolated the language resources in the i18n-2-test branch. There may still be a problem. 6ff5c92c2033d8bb8b5bd3fa1ca7fcee35218b35

You can find the language resources in web/source/vue/i18n.yaml.

virmaior commented 2 years ago

That looks pretty amazing. Do I need to build in docker to use a branch and test it?

mnakada commented 2 years ago

Clone the branch and execute the following to rewrite atomcam's web page.

cd atomcam_tools/web
npm i
./node_modules/.bin/webpack --mode development --progress
scp -p frontend/index.html frontend/bundle_* atomcam.local:/var/www

-> browser reload

If the language selector appears in the upper right corner, the page has been rewritten. There are still some bugs related to the days of the week.

The language resources are in one file for ja and en, but it might be better to separate them.

mnakada commented 2 years ago

I have split the resource file.

mnakada commented 2 years ago

Corrections have been made except for the tooltip. Please correct any strange expressions. Please translate the tooltip if possible.

virmaior commented 2 years ago

resolved in current version and with @mnakada 修正漏れ fixes.