maybe store file as UTF-8?

mnalis / StreetComplete-taginfo-categorize

update list of tags combined with shop=, craft= etc. to populate and categorise tags related to KEYS_THAT_SHOULD_BE_REMOVED_WHEN_PLACE_IS_REPLACED listing in StreetComplete

3 stars 4 forks source link

maybe store file as UTF-8? #28

Closed matkoniecz closed 2 months ago

matkoniecz commented 2 months ago

per github: "We’ve detected the file encoding as ISO-8859-1. When you commit changes we will transcode it to UTF-8."

is github misdetecting it? Or is it actually in weird encoding and can be converted to standard UTF-8?

mnalis commented 2 months ago

(ref. breakage in closed PR https://github.com/mnalis/StreetComplete-taginfo-categorize/pull/25)

It also seems the issue was encoutered before too: https://github.com/mnalis/StreetComplete-taginfo-categorize/commit/d5c5346f1fda0cabbcc9dc55930c215173d70869

mnalis commented 2 months ago

Well not actually fixed in code, but the problem is gone, as the problematic key in no longer in database, see https://community.openstreetmap.org/t/faroe-islands-address-metadata-cleanup-proposed-mass-edit/109790/5

If it happens with another UTF8 tag, we can debug it then...